Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration image missing #22

Open
Fettkeewl opened this issue Nov 29, 2023 · 5 comments
Open

Integration image missing #22

Fettkeewl opened this issue Nov 29, 2023 · 5 comments

Comments

@Fettkeewl
Copy link

Just a minor inconvenience

Missing integration image in HA
Integration view
Device view

@bj00rn
Copy link
Owner

bj00rn commented Dec 7, 2023

brand image need to be uploaded to home assistant brand repo.

I think domain should be changed first though. right now it's saleryd_hrv. Should probably be just saleryd to keep things neat. Not sure how to to this is without breaking existing installations

@Fettkeewl
Copy link
Author

I'm not sure it would break anything..
All the entities seem to be looking at the config_entry ID to "tie" them together.
I imagine we could have some wrong friendly names displayed in the Home Assistant UI but other than that
it should work in theory..

Perhaps add to the integration in, it's start-up sequence, a small script to search and replace "saleryd_hrv" for "saleryd"
in
core.config_entries
core.device_registry
core.entity_registry

just thinking out loud

image

@bj00rn
Copy link
Owner

bj00rn commented Dec 14, 2023

I think this will have to wait until a major release. PRs are welcome though. I think there is some kind of migration framework for this kind of stuff.

There are some other breaking stuff what should probably go in there as well, like naming the instance etc.

@bj00rn
Copy link
Owner

bj00rn commented Nov 9, 2024

@Fettkeewl (or anyone else) feel free to do a PR on https://github.com/home-assistant/brands with brand images if you are up for it. Use domain saleryd_hrv if you do.

see home-assistant/brands@089b8b9 for an example

@Fettkeewl
Copy link
Author

@bj00rn thanks for the vote of confidence haha but artistry is not my forte.
However I did try for the fun of it while my son allowed me to mock something up as a temporary solution or just an idea to work around :P

Feel free to discard them if your not satisfied, I wont sully your integration with my "art" ;)

logo
logo@

icon
icon@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants