[BUG] Infinite loop while loading a savegame

[krzychu124]

If something go wrong and NetInfo of the node will be null (possible if not all assets are subscribed/enabled) this method will cause infinite loop - game never finish loading a savegame. I've noticed that while testing the user savegame

Skylines-MetroOverhaulMod/AssetsUpdater.cs

Lines 430 to 451 in c94dea3

	private static List<ushort> GetMetroNodes(Building building)
	{
	ushort nodeID = building.m_netNode;
	List<ushort> stationNodeIDs = null;
	while (nodeID > 0)
	{
	NetNode node = NodeFrom(nodeID);
	if (node.Info != null)
	{
	if (node.Info.IsUndergroundMetroStationTrack() || node.Info.name == Util.GetMetroStationTrackName(NetInfoVersion.Tunnel, TrackStyle.Vanilla) || node.Info.IsUndergroundMetroTrack() || node.Info.name == Util.GetMetroTrackName(NetInfoVersion.Tunnel, TrackStyle.Vanilla))
	{
	if (stationNodeIDs == null)
	{
	stationNodeIDs = new List<ushort>();
	}
	stationNodeIDs.Add(nodeID);
	}
	nodeID = NodeFrom(nodeID).m_nextBuildingNode;
	}
	}
	return stationNodeIDs;
	}

The instruction from line 447 should be placed outside of if (node.Info != null) check to prevent infinite loop.

Similar situation you can find just a few lines below but the code is correct there.

Skylines-MetroOverhaulMod/AssetsUpdater.cs

Lines 452 to 470 in c94dea3

	private static List<ushort> GetStationNodes(Building building)
	{
	ushort nodeID = building.m_netNode;
	List<ushort> stationNodeIDs = null;
	while (nodeID > 0)
	{
	NetNode node = NodeFrom(nodeID);
	if (node.Info != null && (node.Info.IsUndergroundMetroStationTrack() || node.Info.name == Util.GetMetroStationTrackName(NetInfoVersion.Tunnel, TrackStyle.Vanilla)))
	{
	if (stationNodeIDs == null)
	{
	stationNodeIDs = new List<ushort>();
	}
	stationNodeIDs.Add(nodeID);
	}
	nodeID = NodeFrom(nodeID).m_nextBuildingNode;
	}
	return stationNodeIDs;
	}