Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiping backwards instead of using the back arrow undoes theme changes #50

Open
cameronj86 opened this issue Nov 28, 2024 · 4 comments
Open

Comments

@cameronj86
Copy link

For example, if the app is set to light and I switch to dark, if swipe back to the home-screen the app will revert to light again.

Great app in general btw. It's ironic that such a young developer's weather app has solid aesthetics that capture a mature, minimalist vibe relative to a lot of the cartoony alternatives.

@bmaroti9
Copy link
Owner

bmaroti9 commented Dec 1, 2024

Hi! Wow i didn't know if i included the number of this issue in my commit, it would auto close... my bad. I was just experimenting 😂.
So if fixed it:

Screencast.From.2024-12-01.17-50-25.mp4

Also thanks for all the compliments on the ui!
Should be in next version

@bmaroti9
Copy link
Owner

When i released v2.4.4 and tried it on my phone this stopped me from exiting the settings page (even though it works on the emulator). This was a critical issue because the only way to get out was to reopen the app, and you couldn't even set any setting since you couldn't go back. So i quickly reverted this change and re released v2.4.4 without this.
I have no idea why it failed on my phone and not the emulator (but i guess others would have had the same issue)
I will try to fix it, no idea what is even happening.
But unfortunately it is not in v2.4.4, so i'm reopening.

@bmaroti9 bmaroti9 reopened this Dec 18, 2024
@bmaroti9
Copy link
Owner

bmaroti9 commented Jan 4, 2025

Hi!
So I found another solution. As it turns out the method i was using for the previous solution was mainly used to stop the back arrow from doing anything and using it to solve this was very hacky. this new solution is much better and cleaner and obviously the right way to do it, I wish i found this one first.

Screencast.From.2025-01-04.17-41-57.mp4

@cameronj86
Copy link
Author

Looks good! thanks for doubling back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants