LicenseTextExistsCheck fails on GPL-3.0-or-later

[matthias-mayr]

I also ran this against our iiwa_ros repo.

It's a metapackage and the first observation is that it could not be run in the root repo folder and not in the iiwa_ros subfolder, but that's not what the issue is about.

The repo is "GPLv3.0 and later" licensed. After making the package.xml license statement SPDX compliant it still states this:

Found 1 packages in .
====================
[iiwa_driver]
git hash of (/home/matthias/Workspaces/iiwa_ros_ws/src/iiwa_ros): 0f0041cef81cb9ea1cf4f27ecef1fa9b470df991
LicenseTagExistsCheck
 SUCCESS Found licenses ['GPL-3.0-or-later']
LicenseTagIsInSpdxListCheck
 SUCCESS All license tags are in SPDX list of licenses.
LicenseTextExistsCheck
 FAILURE The following license tags do not have a valid license text file:
  'GPL-3.0-or-later': License text file '../LICENSE' is of license GPL-3.0-only but should be GPL-3.0-or-later.
LicensesInCodeCheck
 SUCCESS All licenses found in the code are covered by a license declaration.

However even on spdx.org GPL-3.0-or-later and GPL-3.0 have exactly the same text and copying the GPL-3.0-or-later-text from the website with its different linebreaks does not help either.

Probably the false positive comes from a library, but it should still be handled somehow. Worst-case with an ignore list.

[matthias-mayr]

I had a similar issue with SkiROS2 with LGPL if I didn't have this snippet above the actual license text:

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License below for more details.

Probably sth similar would work for GPL as well.

It might still be worthwhile to communicate it. Maybe through sth like a Troubleshooting section in the readme.