Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pages changes #26

Open
bradygaster-zz opened this issue Apr 3, 2017 · 0 comments
Open

Review pages changes #26

bradygaster-zz opened this issue Apr 3, 2017 · 0 comments

Comments

@bradygaster-zz
Copy link
Owner

After a lot of review and testing I'm excited to let everyone contributing to the project that we're close to getting the pages branch moved into master. As it stands today here are the changes I've made recently to this branch I want to submit for review to all the contributors, and ask for help from each of you to finalize this long-awaited merge.

@BenjaminAbt - could you take a look at the changes I've made to how your initial contributions of pages work. I've removed the dependency on category metadata from the page object. Customers will want to put links to pages in their nav, so categorizing pages seemed like something that shouldn't be required so I made it optional. I think there is a bug in here wherein pages aren't shown on the category page. The forward/backward feature didn't seem relevant on pages, so I've moved it to the post template. @BenjaminAbt - Could you please review the changes I've made and let me know if you're concerned about anything?

One more thing - as it stands now, each of the blog posts requires the user remember to include the posts prefix in their slugs. So when I want to write a post named introducing-productx I have to make sure to make the slug posts/introducing-productx. This is a little inconvenient - could you revert this to the original state, where the default assumption is that content is a blog post, so users won't need to specifically include it in their slugs?

@spboyer - I've added a build.bat and run.bat script to the repo as I was having major issues getting npm, grunt, bower, and bundle all working the right way following migration to *.csproj format. I'm concerned that the way I've done this will:

  1. Make deployment to Azure more difficult or obtuse
  2. Fail to make use of MSBuild-based building, thereby making CI more difficult in general

That said, I tried numerous ways to accomplish this and failed miserably. Any ideas here would be much appreciated.

@stuartleeks - I'd like to get your eyes on this to make the vscode debugging experience better. Right now it - it's not working. :) Any ideas on streamlining the build/debug process would be much appreciated.

Thanks to each of you for taking a few minutes out of your busy schedules over the next few weeks to give your 2C to where we are. I think we're REALLY close to being able to merge the pages functionality into downr's master, which will make it more like a CMS than a simple blogging tool, which I think could add some value to some users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant