From 6a559d7382431e43ef522a4ecfc06db515ea2e41 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 25 Dec 2024 16:13:40 -0500 Subject: [PATCH 1/3] Allow ruby version 3.4 in gemspec --- flatware-cucumber.gemspec | 2 +- flatware-rspec.gemspec | 2 +- flatware.gemspec | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/flatware-cucumber.gemspec b/flatware-cucumber.gemspec index 06aa853..47b6694 100644 --- a/flatware-cucumber.gemspec +++ b/flatware-cucumber.gemspec @@ -20,7 +20,7 @@ Gem::Specification.new do |s| ) s.homepage = 'http://github.com/briandunn/flatware' s.licenses = ['MIT'] - s.required_ruby_version = ['>= 2.6', '< 3.4'] + s.required_ruby_version = ['>= 2.6', '< 3.5'] s.require_paths = ['lib'] s.add_dependency %(cucumber), '~> 3.0' s.add_dependency %(flatware), Flatware::VERSION diff --git a/flatware-rspec.gemspec b/flatware-rspec.gemspec index 557655f..d534c32 100644 --- a/flatware-rspec.gemspec +++ b/flatware-rspec.gemspec @@ -21,7 +21,7 @@ Gem::Specification.new do |s| ) s.homepage = 'http://github.com/briandunn/flatware' s.licenses = ['MIT'] - s.required_ruby_version = ['>= 2.6', '< 3.4'] + s.required_ruby_version = ['>= 2.6', '< 3.5'] s.require_paths = ['lib'] s.add_dependency %(flatware), Flatware::VERSION s.add_dependency %(rspec), '>= 3.6' diff --git a/flatware.gemspec b/flatware.gemspec index 4f49eb5..20121be 100644 --- a/flatware.gemspec +++ b/flatware.gemspec @@ -26,7 +26,7 @@ Gem::Specification.new do |s| s.homepage = 'http://github.com/briandunn/flatware' s.licenses = ['MIT'] - s.required_ruby_version = ['>= 2.6', '< 3.4'] + s.required_ruby_version = ['>= 2.6', '< 3.5'] s.require_paths = ['lib'] s.executables = ['flatware'] s.add_dependency %(drb) From fec321210fa29e36055589b7bbab73056b485c45 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 25 Dec 2024 16:17:43 -0500 Subject: [PATCH 2/3] Add ruby 3.4 to CI matrix --- .github/workflows/ruby.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 602abfb..36d80ac 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -20,7 +20,7 @@ jobs: strategy: matrix: rspec-minor-versions: [6, 7, 8, 9, 10, 11, 12, 13] - ruby-versions: ["3.1", "3.2", "3.3"] + ruby-versions: ["3.1", "3.2", "3.3", "3.4"] env: BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rspec_3.${{ matrix.rspec-minor-versions }}.gemfile From 1931edc85398704681ab5ef0a128b113aea07b2d Mon Sep 17 00:00:00 2001 From: "Javier G. Montoya S" Date: Thu, 26 Dec 2024 17:11:08 -0300 Subject: [PATCH 3/3] fix(features/rspec.feature): ignore backtick on failure message check --- features/rspec.feature | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/features/rspec.feature b/features/rspec.feature index e73dd5b..8b584ac 100644 --- a/features/rspec.feature +++ b/features/rspec.feature @@ -28,7 +28,11 @@ Feature: rspec task """ And the output contains the following: """ - # ./spec/spec_spec.rb:2:in `block (2 levels) in ' + # ./spec/spec_spec.rb:2:in + """ + And the output contains the following: + """ + block (2 levels) in ' """ Scenario: it behaves like