Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Buffer API #20

Closed
kibertoad opened this issue Jan 21, 2024 · 5 comments
Closed

Deprecated Buffer API #20

kibertoad opened this issue Jan 21, 2024 · 5 comments

Comments

@kibertoad
Copy link
Collaborator

This library uses new Buffer, which is deprecated. Buffer.allocUnsafe should be used instead

Would you be open to a PR fixing this?

@brianloveswords
Copy link
Owner

I'd be open to that PR!

@kibertoad
Copy link
Collaborator Author

@brianloveswords Thank you! Since Travis CI stopped working long time ago (and is no longer a good option for OSS), I've opened a PR to add GitHub Actions CI, to ensure that changes won't break anything: #21

@kibertoad
Copy link
Collaborator Author

@brianloveswords I only now realised that you actually have a check in your code already that only uses old API for old Node versions. Do you still intend to support all of Node versions, or you are open to releasing a new semver major dropping support for anything below Node 8?

@brianloveswords
Copy link
Owner

@kibertoad I'm open to a major bump that drops old versions

@brianloveswords
Copy link
Owner

fixed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants