Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha v3 support #185

Closed
paulfalgout opened this issue Aug 14, 2017 · 2 comments
Closed

Mocha v3 support #185

paulfalgout opened this issue Aug 14, 2017 · 2 comments

Comments

@paulfalgout
Copy link

It looks like mocha 3 may not be supported. This #179 might fix it, but what I'm seeing is only the passing test stat is getting recorded and all other values are showing up NaN This means if a test fails, it doesn't fail the run.

@AlexanderOMara
Copy link

AlexanderOMara commented Nov 26, 2017

Mocha v4 also seems to be non-functional, as I just discovered while attempting to setup some Mocha unit tests.

@mohitmun
Copy link
Contributor

@AlexanderOMara Mocha v4 is functional. Can you provide me more details on what broke when you were trying to setup tests?
One issue which I figure was with url.js. we use this repo to conduct integration tests. testing url.js against mocha 4 would report zero tests passed. this is because url.js has some node runtime check

if ( typeof require == "function" )
{
	var chai = require("chai");
	var url  = require("../url");
}

which would conflict with Mocha v4(as it had function named 'require' defined in it). when removing above check, it started working as expected.
I also tested against v3 and v5. checked again all minor and major versions.
Correct me if I have missed something.

Closing this issue for now, reopen with more details if issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants