Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test for erase() #57

Open
bumbummen99 opened this issue Jan 10, 2020 · 1 comment
Open

Create test for erase() #57

bumbummen99 opened this issue Jan 10, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest Label help wanted Extra attention is needed

Comments

@bumbummen99
Copy link
Owner

The Cart::erase() method has no unit test affecting coverage and production security. The Cart::erase() method should have a unit test verifying its functionality.

To verify:

  • Create Cart with known instance id
  • Add item to Cart
  • Store Cart
  • Erase Cart
  • Restore Cart
  • Verify that Cart is empty.
  • (Optional) Verify that database is empty
@bumbummen99 bumbummen99 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 10, 2020
This was referenced May 2, 2020
Closed
Closed
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Inactive, will be closed soon. label Sep 26, 2020
@bumbummen99 bumbummen99 added the Hacktoberfest Hacktoberfest Label label Sep 30, 2020
Repository owner deleted a comment Feb 17, 2021
@github-actions github-actions bot removed the stale Inactive, will be closed soon. label Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest Label help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added erase() test and new exception instead of just returning nothing nexxai/LaravelShoppingcart
1 participant
@bumbummen99