Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive Yggdrasil requests are created resulting in ratelimiting #123

Open
maladaptly opened this issue Jun 22, 2019 · 3 comments
Open
Assignees
Labels
Enhancement suggested enhancement to the mod Help Wanted Help is wanted to either determining the cause or with fixing the issue More Info Needed More information about the issue is needed before any further action can be taken

Comments

@maladaptly
Copy link

The most obvious symptom is that this shows up repeatedly in the server log:

[23:09:23] [Thread-129/WARN] [mojang/YggdrasilMinecraftSessionService]: Couldn't look up profile properties for com.mojang.authlib.GameProfile@75738860[id=966ebb69-a63d-4bb2-ac90-ed39d8c64b80,name=generikb,properties={},legacy=false]
com.mojang.authlib.exceptions.AuthenticationException: The client has sent too many requests within a certain amount of time
        at com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService.makeRequest(YggdrasilAuthenticationService.java:79) ~[YggdrasilAuthenticationService.class:?]
        at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillGameProfile(YggdrasilMinecraftSessionService.java:180) [YggdrasilMinecraftSessionService.class:?]
        at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillProfileProperties(YggdrasilMinecraftSessionService.java:173) [YggdrasilMinecraftSessionService.class:?]
        at net.minecraft.tileentity.TileEntitySkull.func_174884_b(SourceFile:151) [awd.class:?]
        at ganymedes01.headcrumbs.utils.ThreadedProfileFiller$1.run(ThreadedProfileFiller.java:25) [ThreadedProfileFiller$1.class:?]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

The mod should stagger queries so as to not hammer the Yggdrasil service.

@TheTurkeyDev
Copy link
Collaborator

The mod only makes a request when it is needed, i.e when a mob is spawned. I can try and add a rate limit, but I would need to know that limit

@TheTurkeyDev TheTurkeyDev added Enhancement suggested enhancement to the mod Help Wanted Help is wanted to either determining the cause or with fixing the issue More Info Needed More information about the issue is needed before any further action can be taken labels Jun 27, 2019
@TheTurkeyDev TheTurkeyDev self-assigned this Jun 27, 2019
@ByteTemplar
Copy link

ByteTemplar commented Sep 14, 2019

I have blocked Java access to network (security reasons) and because of that, I get even more spam in the log, cause it is constantly trying to connect the servers (getting connection refused error and trying the next name in constant loop). Filling my log file with thousands of lines very fast.

I know one of the mods ideas is to have known player models, but maybe have config option to disable getting the skins.

@GreyMario
Copy link

This is happening... again.

Frankly, this is something that the far end should account for, as it probably does something incredibly silly like impact large servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement suggested enhancement to the mod Help Wanted Help is wanted to either determining the cause or with fixing the issue More Info Needed More information about the issue is needed before any further action can be taken
Projects
None yet
Development

No branches or pull requests

4 participants