Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sinogram weights to calculate sino_indicator #46

Open
dyang37 opened this issue Nov 18, 2021 · 2 comments
Open

Use sinogram weights to calculate sino_indicator #46

dyang37 opened this issue Nov 18, 2021 · 2 comments
Assignees

Comments

@dyang37
Copy link
Collaborator

dyang37 commented Nov 18, 2021

Currently unweighted sinogram is used to calculate sino_indicator:

indicator = np.int8(sino > 0.05 * np.mean(np.fabs(sino)))

This would cause problem when "bad" values exist in sino (inf, nan etc.)
Usually such case is handled by setting the associated sino weights to be 0 for the "bad" sino values.
As a result we should also use weights when calculating the indicator in _sino_indicator function. Maybe a good start point is to try using the weighted sino.

@dyang37
Copy link
Collaborator Author

dyang37 commented Nov 18, 2021

There's a mirror issue in svmbir: cabouman/svmbir#221

@cabouman
Copy link
Owner

Let me modify this. The potential problem is in the function `auto_sigma_prior(sino,delta_channel = 1.0,sharpness = 0.0 )``.

Should this function use the weighted sinogram?

If so, then we would need to modify auto_sigma_prior(), auto_sigma_x() , and auto_sigma_p() so they all take the weights as an input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants