Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add connection role to SQL Log Panel queries #1033

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

LordSimal
Copy link
Contributor

Fixes #1003

image

@LordSimal LordSimal added this to the 5.x milestone Dec 29, 2024
@@ -153,6 +154,9 @@ public function log($level, string|Stringable $message, array $context = []): vo
], JSON_PRETTY_PRINT),
'took' => $took,
'rows' => $context['response']['hits']['total']['value'] ?? $context['response']['hits']['total'] ?? 0,
'inTransaction' => $this->inTransaction,
'isCommitOrRollback' => false,
'role' => '',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to make it consistent for Elastic Search query logging as well

@LordSimal
Copy link
Contributor Author

@ryanolton would this be what you wanted?

@ryanolton
Copy link

@LordSimal yes, that looks fantastic, thanks!

@LordSimal LordSimal merged commit b83ec9e into 5.x Dec 30, 2024
9 checks passed
@LordSimal LordSimal deleted the 5.x-connection-role branch December 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read connections in SQL Log panel?
2 participants