Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isTypeOf config parameter missing from StrongObjectTypeConfig type #3

Open
karoun opened this issue Dec 28, 2017 · 0 comments
Open

Comments

@karoun
Copy link

karoun commented Dec 28, 2017

The isTypeOf option is mentioned in the README, but isn't implemented in source:

graphql-strong/README.md

Lines 187 to 189 in c85a0c7

- `name: string`: The required name of your type.
- `description?: string`: An optional description of your type.
- `isTypeOf: (value: any, context: TContext) => value is TValue`: A function you define which will verify if a value is indeed of the type you created.

/**
* A configuration object to be used when creating object types. Any extra
* options will go straight into the type config.
*/
export type StrongObjectTypeConfig<TValue, TContext> = {
readonly name: string,
readonly description?: string | undefined,
};

It should be added to the StrongObjectTypeConfig type as an optional parameter.

@karoun karoun changed the title isTypeOf config option missing from StrongObjectTypeConfig type isTypeOf config parameter missing from StrongObjectTypeConfig type Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant