Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_save_articles doesn't test if saving article succeeded, leading to poor error detection #7

Open
mhucka opened this issue Jul 3, 2022 · 1 comment
Open

_save_articles doesn't test if saving article succeeded, leading to poor error detection #7

mhucka opened this issue Jul 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mhucka
Copy link
Contributor

mhucka commented Jul 3, 2022

_save_articles doesn't test if saving article succeed, and thus can't deal cases where article is in the article.xml but something goes wrong when actual download is attempt. need to catch the error, then write exceptions so they can be tried next time
@mhucka mhucka added the enhancement New feature or request label Jul 3, 2022
@mhucka
Copy link
Contributor Author

mhucka commented Jul 3, 2022

Also see our meeting notes from 2022-04-11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhucka