Update exception hierarchy #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knkski
force-pushed
the
new-exception-hierarchy
branch
from
1c28d59 to
d6e68f2
Compare
johnsca
reviewed
Dec 7, 2021
| @@ -17,7 +17,19 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| class NoCompatibleVersions(Exception): | |||
| class SDIError(Exception): | |||
| status = BlockedStatus | |||
There was a problem hiding this comment.
What about instead doing something like:
Suggested change
| status = BlockedStatus | |
| status_class = BlockedStatus | |
| @property | |
| def status(self): | |
| return self.status_class(str(self)) |
There was a problem hiding this comment.
agreed, the other examples (OCIImageResourceError and CheckFailed) have .status as a fully instantiated status, not a recommended class. Either property or actual status is fine with me
|
An aside for when this gets pushed/published: lots of charms import/watch for the old errors, so we should make sure to bump SDI version to at least |
Adds a package-level exception that FatalError and MaybeFatalError inherit from, which in turn every other exception inherits from. Also adds `status` field with suggested charm status.
knkski
force-pushed
the
new-exception-hierarchy
branch
from
d6e68f2 to
a431a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a package-level exception that
FatalErrorandMaybeFatalErrorinherit from, which in turn every other exception inherits from. Also addsstatusfield with suggested charm status.Fixes #26