Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide debug symbols in a separate release artifact #659

Open
passcod opened this issue Jan 7, 2023 · 7 comments · Fixed by #696
Open

Provide debug symbols in a separate release artifact #659

passcod opened this issue Jan 7, 2023 · 7 comments · Fixed by #696
Labels
Report: feature request New feature request

Comments

@passcod
Copy link
Member

passcod commented Jan 7, 2023

For those who want those, given we produce them during build anyway we def could package them up

@passcod passcod added the Report: feature request New feature request label Jan 7, 2023
@NobodyXu
Copy link
Member

NobodyXu commented Jan 7, 2023

For those who want those, given we produce them during build anyway we def could package them up

I think that requires binstall to remove the strip = "symbols" from Cargo.toml and manually strip out debug info and symbols into a separate file.

Currently while split-debuginfo is stable, its option packed and unpacked is unstable and I'm not sure how it interacts with strip.

Edit:

Just realize that we use nightly for build, so we can simply override the default profiles and tries to use split-debuginfo=packed for windows and split-debuginfo=unpacked for other.

@NobodyXu
Copy link
Member

NobodyXu commented Jan 9, 2023

Can we close this PR now since the full archive is added @passcod ?

@passcod passcod closed this as completed Jan 9, 2023
@passcod
Copy link
Member Author

passcod commented Jan 12, 2023

Re-opening as the dSYM folder in the packaging is empty on mac builds, and the pdb is just not there for windows builds >:(

@passcod passcod reopened this Jan 12, 2023
passcod added a commit that referenced this issue Jan 12, 2023
This will fix #659 for mac
@passcod passcod reopened this Jan 12, 2023
@passcod
Copy link
Member Author

passcod commented Jan 12, 2023

Yeah, that's more like it:
image

@passcod
Copy link
Member Author

passcod commented Jan 12, 2023

I'll figure out the windows thing when I test #650 this weekend

@NobodyXu
Copy link
Member

Yeah, release builds artifacts size now looks kind of right.

image

image

@NobodyXu
Copy link
Member

From our CI, it seems that the .pdb files are not present @passcod :

cp -r target/aarch64-pc-windows-msvc/release/deps/cargo_binstall.pdb packages/prep/cargo_binstall.pdb
cp: cannot stat 'target/aarch64-pc-windows-msvc/release/deps/cargo_binstall.pdb': No such file or directory
error: Recipe `get-output` failed on line 194 with exit code 1
just get-output detect-wasi.exe packages/prep
test -d "packages/prep" || mkdir -p packages/prep
cp -r target/aarch64-pc-windows-msvc/release/detect-wasi.exe packages/prep/detect-wasi.exe
ls -l packages/prep/detect-wasi.exe
-rwxr-xr-x 1 runneradmin 197121 218112 Jun 23 04:37 packages/prep/detect-wasi.exe
just get-output deps/detect_wasi.pdb packages/prep
test -d "packages/prep" || mkdir -p packages/prep
cp -r target/aarch64-pc-windows-msvc/release/deps/detect_wasi.pdb packages/prep/detect_wasi.pdb
cp: cannot stat 'target/aarch64-pc-windows-msvc/release/deps/detect_wasi.pdb': No such file or directory
error: Recipe `get-output` failed on line 194 with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Report: feature request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants