Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link on Whitmore Score popup #163

Open
rafal-watorski opened this issue Sep 11, 2021 · 11 comments
Open

Broken link on Whitmore Score popup #163

rafal-watorski opened this issue Sep 11, 2021 · 11 comments

Comments

@rafal-watorski
Copy link

rafal-watorski commented Sep 11, 2021

It seems that the geeklist https://boardgamegeek.com/geeklist/37832/my-favorite-designers (link on the Whitmore Score popup) no longer exists.

Screenshot_2021-09-10-22-24-13-319_com boardgamegeek

@Kaligula0
Copy link
Contributor

@Kaligula0
Copy link
Contributor

@Kaligula0
Copy link
Contributor

This bug was filed already #143 and fixed 09ceb19 but not released yet.

However, what do you think of updating such links to the BGG for Android Users Manual (link 3 above)?

@rafal-watorski
Copy link
Author

I don't have a strong preference, but I would go with third option with anchor, so https://boardgamegeek.com/wiki/page/BGG_for_Android_Users_Manual#toc23

@Kaligula0
Copy link
Contributor

Filed a Pull request #165

@Kaligula0
Copy link
Contributor

ccomeaux merged PR #165

@Kaligula0
Copy link
Contributor

solved?

@rafal-watorski
Copy link
Author

It's either not released yet or still not solved. I have the 6.8.2 (latest version) installed and the old link is still there.

@Kaligula0
Copy link
Contributor

I have the 6.8.2, too, but I cannot find the link in the app. So I checked the code here and 1) it's commented out, 2) the commit was before the release; so it made sense to me that it's released...

@rafal-watorski
Copy link
Author

Open any game, then the "CREDITS" tab, then click on a designer and go to the "STATS" tab. Click on the "Whitmore Score".

@Kaligula0
Copy link
Contributor

Oh, there! You're right, there still it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants