Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(native_dio_adapter): bump cronet_http dependency #2005

Merged
merged 2 commits into from
Oct 21, 2023
Merged

feat(native_dio_adapter): bump cronet_http dependency #2005

merged 2 commits into from
Oct 21, 2023

Conversation

dkrutskikh
Copy link
Contributor

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@dkrutskikh dkrutskikh requested a review from a team as a code owner October 21, 2023 17:17
ueman
ueman approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ueman
Copy link
Contributor

ueman commented Oct 21, 2023

@dkrutskikh Is the lint upgrade the reason for the new lint failures?

@dkrutskikh
Copy link
Contributor Author

@ueman I was revert lints package version

@ueman
Copy link
Contributor

ueman commented Oct 21, 2023

Apparently it was not the reason. The failures are unrelated. Thanks again!

@ueman ueman added this pull request to the merge queue Oct 21, 2023
Merged via the queue into cfug:main with commit fad3fb8 Oct 21, 2023
18 of 19 checks passed
@AlexV525 AlexV525 added the p: native_dio_adapter Targeting `native_dio_adapter` package label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
p: native_dio_adapter Targeting `native_dio_adapter` package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkrutskikh @ueman @AlexV525