Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Replace HttpAdapter names on README #2012

Closed
deandreamatias-worldline opened this issue Oct 26, 2023 · 2 comments · Fixed by #2016
Closed

[Documentation] Replace HttpAdapter names on README #2012

deandreamatias-worldline opened this issue Oct 26, 2023 · 2 comments · Fixed by #2016
Assignees
@someshwar16
Labels
e: documentation Improvements or additions to documentation fixed

Comments

@deandreamatias-worldline
Copy link

Request Statement

  1. The class BrowserClientAdapter do not exist on package:dio/browser.dart but on README HttpClientAdapter section, show BrowserClientAdapter like example.
  2. The class IOClientAdapter do not exist on package:dio/io.dart but on README HttpClientAdapter section, show IOClientAdapter like example.

Solution Brainstorm

Replace IOClientAdapter to IOHttpClientAdapter on both README
Replace BrowserClientAdapter to BrowserHttpClientAdapter on both README
@deandreamatias-worldline deandreamatias-worldline added the s: feature This issue indicates a feature request label Oct 26, 2023
@someshwar16
Copy link
Contributor

Hi, I can do this work can I be assigned to this issue?

@ueman
Copy link
Contributor

ueman commented Oct 31, 2023

@someshwar16 feel free to work on this. There's no need to be assigned. Thank you!

@ueman ueman added e: documentation Improvements or additions to documentation e: good for newcomers Good for newcomers e: PR welcomed and removed s: feature This issue indicates a feature request labels Oct 31, 2023
@ueman ueman mentioned this issue Nov 1, 2023
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 1, 2023
@someshwar16
Changes made in both Readme files (#2016)
d671177 
Fixes #2012

<!-- Write down your pull request descriptions. -->

### New Pull Request Checklist

- [x] I have read the
[Documentation](https://pub.dev/documentation/dio/latest/)
- [ ] I have searched for a similar pull request in the
[project](https://github.com/cfug/dio/pulls) and found none
- [ ] I have updated this branch with the latest `main` branch to avoid
conflicts (via merge from master or rebase)
- [ ] I have added the required tests to prove the fix/feature I'm
adding
- [x] I have updated the documentation (if necessary)
- [ ] I have run the tests without failures
- [ ] I have updated the `CHANGELOG.md` in the corresponding package

### Additional context and info (if any)

Replaced **IOClientAdapter** to **IOHttpClientAdapter** on both readme
and replaced **BrowserClientAdapter** to **BrowserHttpClientAdapter** on
both readme.
@AlexV525 AlexV525 added fixed and removed e: PR welcomed e: good for newcomers Good for newcomers labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@someshwar16 someshwar16

Labels
e: documentation Improvements or additions to documentation fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes made in both Readme files someshwar16/dio
4 participants
@ueman @AlexV525 @someshwar16 @deandreamatias-worldline