Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android artifacts for 0.8.0 weren't published #8

Closed
tadfisher opened this issue Jan 16, 2024 · 4 comments
Closed

Android artifacts for 0.8.0 weren't published #8

tadfisher opened this issue Jan 16, 2024 · 4 comments

Comments

@tadfisher
Copy link

Looking at the Maven repository index, the following artifacts weren't published for version 0.8.0:

The Gradle module metadata is missing the android*Elements-published variants, so upgrading to 0.8.0 results in Gradle selecting the JVM variant for Android builds, which is definitely broken.

@chRyNaN
Copy link
Owner

chRyNaN commented Jan 19, 2024

Good catch, I think I know what the issue is. Will try and get an update out today. https://github.com/chRyNaN/serialization-parcelable/blob/develop/parcelable-core/build.gradle.kts#L20

@chRyNaN
Copy link
Owner

chRyNaN commented Jan 19, 2024

@tadfisher Could you try again? It looks like the android artifacts are now available. This was the issue:

// Before:
androidTarget()

// After:
androidTarget {
        publishAllLibraryVariants()
}

@chRyNaN
Copy link
Owner

chRyNaN commented Jan 19, 2024

BTW JVM should not be broken, if it is please file an issue. But JVM doesn't have the Android components or functionality (Intent, Bundle, etc).

@tadfisher
Copy link
Author

But JVM doesn't have the Android components or functionality (Intent, Bundle, etc).

Right, so any Android source set depending on parcelable-core (expecting the Android variant) that uses the Android-specific APIs (encodeToBundle, etc) will fail to compile. I don't actually know if the JVM variant works on Android, to be clear.

Thank you for addressing this!

@chRyNaN chRyNaN closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants