Hide() child in lipgloss/tree

[marcotrosi]

Hello reader,

Question 1

TLDR

how can I hide a child/leaf in a tree without using Root()?

Long question

I have the following code, where I'm trying to hide the second child.

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child("second").Hide(true)
fmt.Println(T)

I understand why it doesn't work, because Child() returns T and not the second child.

I can work my way around by using another Root()

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child(tree.Root("second").Hide(true))
fmt.Println(T)

Okay, but I'm still wondering how to hide that second child without using another Root node. Is it even possible?

I then tried to get the second child and hide it.

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child("second")
T.Children().At(1).Hide(true)
fmt.Println(T)

Which gives the following error message

T.Children().At(1).Hide undefined (type tree.Node has no field or method Hide)

Question 2

I have these 4 code snippets with corresponding output ...

var T *tree.Tree = tree.Root("root")
T.Child("first")
fmt.Println(T)

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child("second")
fmt.Println(T)

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child(tree.Root("second").Hide(true))
fmt.Println(T)

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child(tree.Root("second").Hide(true))
T.Child("third")
fmt.Println(T)

As you can see in snippet number 3 the line is not drawn correctly, it should look like the output of snippet number 1. Is this something I have to take care of myself, or do I have to live with it, or can this safely be considered a bug?

Thank you very much for your support

--marco

[bashbunni]

Hey looking into this - I think there are some bugs that you've pointed out here that we will work on. Thanks for sharing this, it'll be super helpful while we work on fixing this

[bashbunni]

Update: relating to question 1, here's an update to the lipgloss tree that will resolve that issue for you #454

Will work on getting your second point fixed as well :)

[marcotrosi]

Amazing. Thx

Did I get it right, the following code snippet would work with the update?

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child("second")
T.Children().At(1).Hide(true) // <- this
fmt.Println(T)

[bashbunni]

With the changes included in the PR, you would use SetHidden instead of Hide. Hide is for when you're setting a tree to be hidden when it's being created or in other cases where you may want to return that tree

[marcotrosi]

Sorry for my hopefully not too annoying questions, but it's my first Go project.

My use case would indeed be at creation time.
Like in this example which didn't work and probably still won't after the PR, because Child() returns the tree.

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child("second").Hide(true)
fmt.Println(T)

If I got you right then I would have to create the Child() first, then get the Children() from the tree, get the last child which I just created, and then use SetHidden(). Basically this ...

var T *tree.Tree = tree.Root("root")
T.Child("first")
T.Child("second")
T.Children().At(len(T.Children())-1).SetHidden(true)
fmt.Println(T)

Am I missing a simpler solution?
Or I use my workaround where I only use Root() calls, then I can use Hide() directly. I anyway don't understand why there is distinction between Root and Child, and not everything is a Node and either it has children or it hasn't.