Support less fancy terminals

[cjhowedev]

The new bankai has pretty fancy terminal logging! But not everyone runs it in a terminal that supports all these fancy features. For example, term-mode in Emacs really dislikes the fact that bankai takes over the terminal. Also, if you're using bankai on the server side, it can get in the way of your server logging. While I think we should keep these features, I think there should be a configuration option for basic logging (like the old bankai logging) that works on simpler terminals.

We could by default make the decision to use basic or fancy logging based on the TERM environment variable.

[yoshuawuyts]

Ya, agree - we should do a TTY check and then just output a log stream.

…

On Sat, Sep 30, 2017 at 3:27 AM Christian Howe ***@***.***> wrote: The new bankai has pretty fancy terminal logging! But not everyone runs it in a terminal that supports all these fancy features. For example, term-mode in Emacs really dislikes the fact that bankai takes over the terminal. Also, if you're using bankai on the server side, it can get in the way of your server logging. While I think we should keep these features, I think there should be a configuration option for basic logging (like the old bankai logging) that works on simpler terminals. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#251>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWlemAaW_ClNiEwETksj_9aiPFE8rGBks5sne1WgaJpZM4PpeXi> .

[yoshuawuyts]

For now if it doesn't work, you can always pass --silent; it'll only warn on error.

[Flet]

I believe its --quiet :)

bankai --help
  $ bankai <command> [entry] [options]

  Commands:

    build       compile all files to dist/
    inspect     inspect the bundle dependencies
    start       start a development server

  Options:

    -d, --debug       output lots of logs
    -h, --help        print usage
    -q, --quiet       don't output any logs
    -v, --version     print version

[Flet]

Well, I have something kinda working that might help this... I hacked together a version of ui.js that will log to stdout instead.

This allows bankai to be used programmatically without it blowing away existing sever logs :) It would be nice to detect tty but also enable this under a flag... but I'm not certain.

@yoshuawuyts any other thoughts on this?

[Flet]

pushed WIP code to branch if you're interested in seeing it (not merge ready hehe) https://github.com/choojs/bankai/compare/simple-logs

[yoshuawuyts]

@Flet this is cool!