Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query string parsing does not seem to be supported for hash routes #659

Closed
rathagrimes opened this issue May 17, 2018 · 1 comment
Closed

Query string parsing does not seem to be supported for hash routes #659

rathagrimes opened this issue May 17, 2018 · 1 comment

Comments

@rathagrimes
Copy link

Expected behavior

After rendering the below code, when links 3 or 4 are clicked, query should be "{ bar: 'baz' }"
This is expected based on the documentation stating that "Using hashes to delimit routes is supported out of the box (e.g. /foo#bar)" and there was no mention of caveats :)

Actual behavior

href = "/foo?bar=baz" and query = "{}"

Steps to reproduce behavior

const choo = require('choo');
const html = require('choo/html');

const app = choo();

let view = function(state, emit) {
  return html`
<div class="container">
<ol>
<li><a href="/?bar=baz">/?bar=baz</a></li>
<li><a href="/foo?bar=baz">/foo?bar=baz</a></li>
<li><a href="/#foo?bar=baz">/#foo?bar=baz</a></li>
<li><a href="/index.html#foo?bar=baz">/index.html#foo?bar=baz</a></li>
</ol>
<hr/>

<p>Href:
<blockquote><pre>${state.href}</pre></blockquote>
</p>
<p>Query:
<blockquote><pre>${require('util').inspect(state.query)}</pre></blockquote>
</p>
<p>Route:
<blockquote><pre>${state.route}</pre></blockquote>
</p>
</div>
`;
};

app.route('*', view);

app.mount('div');

with index.html of

<!doctype html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <title>QSTest</title>
    <style type="text/css">* { font-family: sans-serif; }</style>
  </head>
  <body>
    <div></div>
    <script src="/bundle.js"></script>
  </body>
</html>

and command line like

./node_modules/.bin/budo -p 8000 --live qstest.js:bundle.js
@tornqvist
Copy link
Member

That's actually the expected behavior. Since a query string is a valid fragment identifier, anything that comes after a # is regarded part of the hash. If you'd like to combine query strings and hash navigation you'd put the query before the hash, i.e. /?bar=baz#foo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tornqvist @rathagrimes