Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering cached components should be done by id only #670

Closed
YerkoPalma opened this issue Jun 27, 2018 · 0 comments
Closed

Rendering cached components should be done by id only #670

YerkoPalma opened this issue Jun 27, 2018 · 0 comments

Comments

@YerkoPalma
Copy link
Member

Expected behavior

After rendering a component like

state.cache(PostPreview, 'post-id').render()

next uses of the same component should be done from cache like

state.cache('post-id').render()

Actual behavior

This call

state.cache('post-id').render()

throws an exception. Even this call

state.cache(null, 'post-id').render()

throws an exception. the only way to do this is by passing a noop to the cache method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant