Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render cached components by id #672

Closed
wants to merge 1 commit into from
Closed

Conversation

YerkoPalma
Copy link
Member

fix #670

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Jul 3, 2018

I think having to use the state.cache(Component, 'id') API everywhere is intentional. There are no guarantees for anything actually being in the cache, so state.cache('id').render() could start throwing if something was removed. Plus, the Component being written in the call means you can read the view code and know which component will be rendered, without having to grep for the ID to try to find where it was defined.

@YerkoPalma
Copy link
Member Author

Oh I see, closing then.

Thanks for the response.

@YerkoPalma YerkoPalma closed this Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering cached components should be done by id only
2 participants