Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Add RTL support #405

Open
cibernox opened this issue May 4, 2018 · 0 comments
Open

[BREAKING] Add RTL support #405

cibernox opened this issue May 4, 2018 · 0 comments

Comments

@cibernox
Copy link
Owner

cibernox commented May 4, 2018

Attack plan:

  • Rename "left" to "start" and "right" to "end" in positioning strategies.
  • Detect if the page is rtl or ltr (checking the dir attribute on the html) and make "start" and "end" flip their calculation based on that.
  • By default the positioning strategy will be "auto-start" (the same way right now is "auto-left"), but we'll add a "reversed" strategy to make it be "auto-end" in ltr pages and "auto-start".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant