Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas to make ebp more accessible #1539

Open
mydea opened this issue Sep 5, 2022 · 1 comment
Open

Ideas to make ebp more accessible #1539

mydea opened this issue Sep 5, 2022 · 1 comment

Comments

@mydea
Copy link
Contributor

mydea commented Sep 5, 2022

Related to #1306, I think there are a few fundamental changes that should be made to make this addon more accessible. Currently, it fails e.g. ember-a11y-testing checks, sometimes in fundamental ways.

IMHO the most straightforward way to make the behavior of this addon more accessible would be:

  1. Make the options in the single select a radio-button list
  2. Move the search of the multi-select into the dropdown (same as in single select), to have no nested interactives in trigger
  3. Make the options in multi select a list of checkboxes
  4. Make the "x" remove functionality in multi-select trigger "optional" (to avoid nested interactives) - you can still remove it via the dropdown.

This is how this looks in our app, as reference:

Screenshot from 2022-09-05 15-21-20

Screenshot from 2022-09-05 15-21-46

With such a setup, I was able to satisfy ember-a11y-testing with a relatively simple setup. It also means that keyboard support for selecting/unselecting items etc. works pretty much out of the box without any special handling.

However, doing anything in this direction would definitely be a breaking change, so not sure if there is any interest in actually pursuing something like this. If so, I'd be happy to write up a PR.

@mkszepp
Copy link
Collaborator

mkszepp commented Dec 15, 2024

Just as note.. we did nr. 2 in #1864 and is released in v8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants