GoLand inspect issues fixed.

[cinar]

Describe Request

GoLand inspect issues fixed.

Change Type

Code maintenance.

Summary by CodeRabbit

• New Features

  • Added constants for default configurations in the trend and volatility packages, enhancing configurability for various strategies.

• Documentation

  • Updated README files and comments across multiple packages for clarity and accuracy, including grammatical corrections and link adjustments.

• Bug Fixes

  • Improved variable naming for clarity in several functions across different packages, ensuring better readability without altering functionality.

• Chores

  • Standardized file removal processes in tests by utilizing a helper function, improving error handling and consistency.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 63.15789% with 21 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (cf5415f) to head (a0b8abe).

Files with missing lines	Patch %	Lines
helper/remove.go	20.00%	7 Missing and 1 partial ⚠️
cmd/indicator-backtest/main.go	0.00%	6 Missing ⚠️
cmd/indicator-sync/main.go	0.00%	6 Missing ⚠️
volatility/moving_std.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   93.59%   93.50%   -0.10%     
==========================================
  Files         174      175       +1     
  Lines        6180     6186       +6     
==========================================
  Hits         5784     5784              
- Misses        337      342       +5     
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a series of minor improvements and refactoring across multiple packages. The changes primarily focus on enhancing code readability, standardizing file removal in tests, and introducing default constants for various indicators. Key modifications include replacing direct os.Remove calls with a new helper.Remove function, renaming variables for clarity, correcting grammatical errors in comments, and adding default configuration constants for different technical indicators.

Changes

File/Group	Change Summary
.gitignore	Added .idea entry to ignore GoLand project files
helper/remove.go	Added Remove and RemoveAll helper functions for file management in tests
Test Files	Replaced os.Remove(fileName) with helper.Remove(t, fileName) across multiple test files
Various Indicator Files	Added default constants (e.g., DefaultApoFastPeriod, DefaultMovingStdPeriod)
Documentation	Corrected grammatical errors and updated comments in various files

Poem

🐰 A Rabbit's Code Refinement Ode 🔧

With gentle paws, I trim and clean,
Removing clutter from the coding scene
Constants added, names made bright
Helper functions bringing testing delight
Refactoring code with bunny-like grace

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf5415f and a0b8abe.

📒 Files selected for processing (76)

• .gitignore (1 hunks)
• asset/README.md (6 hunks)
• asset/file_system_repository_test.go (1 hunks)
• asset/snapshot.go (6 hunks)
• asset/tiingo_repository_test.go (3 hunks)
• backtest/backtest_test.go (4 hunks)
• cmd/indicator-backtest/main.go (2 hunks)
• cmd/indicator-sync/main.go (2 hunks)
• helper/README.md (3 hunks)
• helper/annotation_report_column.go (1 hunks)
• helper/bst.go (5 hunks)
• helper/bst_test.go (1 hunks)
• helper/csv.go (2 hunks)
• helper/csv_test.go (4 hunks)
• helper/reflect_test.go (3 hunks)
• helper/remove.go (1 hunks)
• helper/report_test.go (1 hunks)
• strategy/and_strategy_test.go (1 hunks)
• strategy/buy_and_hold_strategy_test.go (1 hunks)
• strategy/compound/macd_rsi_strategy_test.go (1 hunks)
• strategy/decorator/README.md (1 hunks)
• strategy/decorator/inverse_strategy_test.go (2 hunks)
• strategy/decorator/no_loss_strategy_test.go (2 hunks)
• strategy/decorator/stop_loss_strategy.go (1 hunks)
• strategy/decorator/stop_loss_strategy_test.go (2 hunks)
• strategy/majority_strategy_test.go (1 hunks)
• strategy/momentum/awesome_oscillator_strategy_test.go (1 hunks)
• strategy/momentum/rsi_strategy_test.go (1 hunks)
• strategy/momentum/stochastic_rsi_strategy_test.go (1 hunks)
• strategy/momentum/triple_rsi_strategy_test.go (1 hunks)
• strategy/or_strategy_test.go (1 hunks)
• strategy/split_strategy_test.go (1 hunks)
• strategy/trend/apo_strategy_test.go (1 hunks)
• strategy/trend/aroon_strategy.go (1 hunks)
• strategy/trend/aroon_strategy_test.go (1 hunks)
• strategy/trend/bop_strategy_test.go (1 hunks)
• strategy/trend/cci_strategy_test.go (1 hunks)
• strategy/trend/dema_strategy.go (1 hunks)
• strategy/trend/dema_strategy_test.go (1 hunks)
• strategy/trend/envelope_strategy_test.go (1 hunks)
• strategy/trend/golden_cross_strategy_test.go (2 hunks)
• strategy/trend/kama_strategy_test.go (1 hunks)
• strategy/trend/kdj_strategy_test.go (1 hunks)
• strategy/trend/macd_strategy_test.go (1 hunks)
• strategy/trend/qstick_strategy_test.go (1 hunks)
• strategy/trend/smma_strategy_test.go (1 hunks)
• strategy/trend/trima_strategy.go (1 hunks)
• strategy/trend/trima_strategy_test.go (1 hunks)
• strategy/trend/triple_moving_average_crossover_strategy_test.go (2 hunks)
• strategy/trend/trix_strategy_test.go (1 hunks)
• strategy/trend/tsi_strategy_test.go (1 hunks)
• strategy/trend/vwma_strategy.go (2 hunks)
• strategy/trend/vwma_strategy_test.go (1 hunks)
• strategy/volatility/bollinger_bands_strategy_test.go (1 hunks)
• strategy/volatility/super_trend_strategy_test.go (1 hunks)
• strategy/volume/chaikin_money_flow_strategy_test.go (1 hunks)
• strategy/volume/ease_of_movement_strategy_test.go (1 hunks)
• strategy/volume/force_index_strategy_test.go (1 hunks)
• strategy/volume/money_flow_index_strategy_test.go (1 hunks)
• strategy/volume/negative_volume_index_strategy_test.go (1 hunks)
• strategy/volume/weighted_average_price_strategy_test.go (1 hunks)
• trend/README.md (10 hunks)
• trend/apo.go (1 hunks)
• trend/aroon.go (1 hunks)
• trend/cci.go (1 hunks)
• trend/kama.go (1 hunks)
• trend/moving_max.go (1 hunks)
• trend/moving_max_test.go (1 hunks)
• trend/moving_min.go (1 hunks)
• trend/moving_min_test.go (1 hunks)
• volatility/README.md (11 hunks)
• volatility/acceleration_bands.go (1 hunks)
• volatility/bollinger_band_width.go (1 hunks)
• volatility/chandelier_exit.go (1 hunks)
• volatility/moving_std.go (2 hunks)
• volatility/ulcer_index.go (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.