Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in .zip as a release artifact download option #524

Open
buidav opened this issue Dec 19, 2024 · 3 comments
Open

Add back in .zip as a release artifact download option #524

buidav opened this issue Dec 19, 2024 · 3 comments
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Dec 19, 2024

💡 Summary

PR #499 removes the .zip. However, the documentation still mentions we offer .zip as a release artifact option and zip is more user friendly compared to .tar.gz for specific userbases

Motivation and context

Keep previous release artifact behavior.

Implementation notes

Requires updates to the new release workflow.

Acceptance criteria

Zip is readded as an artifact.

@buidav buidav added this to the Eel milestone Dec 19, 2024
@buidav buidav changed the title The documentation still mentions we offer .zip as a release artifact option. Add back in .zip as a release artifact download option Dec 19, 2024
@buidav buidav modified the milestones: Eel, Driftwood Dec 19, 2024
@rlxdev
Copy link
Collaborator

rlxdev commented Dec 20, 2024

I think GitHub provides the ZIP as a "freebie". This is the result of a "mock" release of ScubaGoggles:

Image

I'm currently generating the .tar.gz, but it looks like that one's free, too.

@snarve
Copy link
Collaborator

snarve commented Jan 15, 2025

@buidav any thoughts?

@buidav
Copy link
Collaborator Author

buidav commented Jan 16, 2025

I think GitHub provides the ZIP as a "freebie". This is the result of a "mock" release of ScubaGoggles:

Image

I'm currently generating the .tar.gz, but it looks like that one's free, too.

That's the entire source repository if we want to remove extraneous files such as tests and workflows we'll need to create an custom zip artifact.
Note. This is also to align ScubaGoggles with ScubaGear's release assets https://github.com/cisagov/ScubaGear/releases/tag/v1.4.0 where a separate zip asset is created with integration tests removed and code signed (though Goggles doesn't need code signing).

Also another note we can't keep track of downloads if someone downloads a not release artifact zip like that source code zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants