Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Rerenders of Geoportal based on published flag. #184

Open
mxfh opened this issue Oct 21, 2024 · 0 comments
Open

Prevent Rerenders of Geoportal based on published flag. #184

mxfh opened this issue Oct 21, 2024 · 0 comments
Labels
Geoportal Re-Render Causes unexpected re-renders in react React

Comments

@mxfh
Copy link
Contributor

mxfh commented Oct 21, 2024

The only element taking the published flag is currently in the topnavbar. So routing awareness only would need to happen there currently. The rest of the app would not be triggered on hash changes then by default and could still listen to hooks embedded with TopNavbar.

Suggestion is moving the App itself above the Router and only let topnavbar be routed.
@mxfh mxfh added Geoportal React Re-Render Causes unexpected re-renders in react labels Oct 21, 2024
@mxfh mxfh closed this as completed Oct 22, 2024
@mxfh mxfh reopened this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Geoportal Re-Render Causes unexpected re-renders in react React
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxfh