Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply vendor for BG Rep #819

Open
Kelzior opened this issue Feb 22, 2016 · 3 comments
Open

Supply vendor for BG Rep #819

Kelzior opened this issue Feb 22, 2016 · 3 comments
Assignees
@cala
Labels
Battleground Core / ScriptDev2 Enhancement Item NPC
Milestone
Stand Your Ground

Comments

@Kelzior
Copy link

Kelzior commented Feb 22, 2016

image

Horde defilers bg supply vendor requires "alliance" rep, which is wrong
same for warsong supply, league of arathor supply vendors ..
@cala cala added this to the Stand Your Ground milestone Feb 22, 2016
@cala
Copy link
Member

cala commented Feb 22, 2016

Indeed, some items were inverted. Thank you for reporting. I added this to our BG milestone: https://github.com/classicdb/database/milestones/Stand%20Your%20Ground

@cala cala self-assigned this Mar 1, 2016
@cala cala mentioned this issue Mar 12, 2016
Closed
cala added a commit that referenced this issue Mar 12, 2016
@cala
[1316] Fixed faction requirements of PvP consumable items
ac49ff0 
* Fixed faction requirements of PvP items (consumables) from BG supply
officers
Thanks @Kelzior and @TheTrueAnimal for reporting. This contributes to
#675 and #819
Sources:
http://wowwiki.wikia.com/wiki/Major_Healing_Draught?oldid=179857
http://www.wowhead.com/item=17348/major-healing-draught#comments
@cala
Copy link
Member

cala commented Mar 12, 2016

Partly fixed in ac49ff0
However, the armor/weapon items cannot be fixed in the current state of the DB/Core because those items have two faction requirements depending on the player's team (on faction for Horde, one for Alliance). Currently, the core/DB can only handle one single faction. This is a specific case for Classic PvP pre-2.0.1
We need to update the core first to be able to fix this, but I don't know what would be the best way to do it.

cala added a commit that referenced this issue Sep 9, 2016
@cala
[1316] Fixed faction requirements of PvP consumable items
cc30483 
* Fixed faction requirements of PvP items (consumables) from BG supply
officers
Thanks @Kelzior and @TheTrueAnimal for reporting. This contributes to
#675 and #819
Sources:
http://wowwiki.wikia.com/wiki/Major_Healing_Draught?oldid=179857
http://www.wowhead.com/item=17348/major-healing-draught#comments
@cala
Copy link
Member

cala commented Jun 22, 2022

Warsong reputation items are fixed in cmangos/classic-db@f069e5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cala cala

Labels
Battleground Core / ScriptDev2 Enhancement Item NPC
Projects
None yet
Milestone
Stand Your Ground
Development

No branches or pull requests
2 participants
@cala @Kelzior