You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would love to integrate kibit into my team's build process, sending out an email to the team whenever a build is started and kibit would suggest code changes.
However, I get false positives because our code includes conditional reader macros which cause RuntimeExceptions in the result. I'd like to be able to suppress these, or direct the suggestions I do care about to a file.
Ideally conditional read macros would not cause a RuntimeException to begin with. But I realize that is a bit of a tough problem to tackle elegantly (maybe just detect and use the clj branch of the macro, if it exists, but that has its own problems).
The text was updated successfully, but these errors were encountered:
Hummmm I'll dig into why reader conditionals blow up. In general because they're reader magic, I don't expect them to be particularly well supported by kibit because any replacements crossing the boundaries of read-cond spicing will be unaware that they're a simplification of some now deleted reader expression. But it should be possible to get at least some support for them.
It would even be awesome if kibit were able to only analyze forms in the same namespace that don't make use of the reader conditional. I appreciate you looking into it.
I would love to integrate kibit into my team's build process, sending out an email to the team whenever a build is started and kibit would suggest code changes.
However, I get false positives because our code includes conditional reader macros which cause RuntimeExceptions in the result. I'd like to be able to suppress these, or direct the suggestions I do care about to a file.
Ideally conditional read macros would not cause a RuntimeException to begin with. But I realize that is a bit of a tough problem to tackle elegantly (maybe just detect and use the clj branch of the macro, if it exists, but that has its own problems).
The text was updated successfully, but these errors were encountered: