Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate conditional read exceptions from kibit suggestions #191

Open
jmromrell opened this issue May 8, 2017 · 2 comments
Open

Separate conditional read exceptions from kibit suggestions #191

jmromrell opened this issue May 8, 2017 · 2 comments

Comments

@jmromrell
Copy link

I would love to integrate kibit into my team's build process, sending out an email to the team whenever a build is started and kibit would suggest code changes.

However, I get false positives because our code includes conditional reader macros which cause RuntimeExceptions in the result. I'd like to be able to suppress these, or direct the suggestions I do care about to a file.

Ideally conditional read macros would not cause a RuntimeException to begin with. But I realize that is a bit of a tough problem to tackle elegantly (maybe just detect and use the clj branch of the macro, if it exists, but that has its own problems).

@arrdem
Copy link
Collaborator

arrdem commented May 9, 2017

Hummmm I'll dig into why reader conditionals blow up. In general because they're reader magic, I don't expect them to be particularly well supported by kibit because any replacements crossing the boundaries of read-cond spicing will be unaware that they're a simplification of some now deleted reader expression. But it should be possible to get at least some support for them.

@jmromrell
Copy link
Author

It would even be awesome if kibit were able to only analyze forms in the same namespace that don't make use of the reader conditional. I appreciate you looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants