Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot Support #197

Open
DonyorM opened this issue Jul 4, 2017 · 2 comments
Open

Boot Support #197

DonyorM opened this issue Jul 4, 2017 · 2 comments

Comments

@DonyorM
Copy link

DonyorM commented Jul 4, 2017

What is the status of kibit's support for boot? I haven't seen a plugin that is equivalent to lein-kibit, is one necessary?

I'm creating a luminus template that uses boot, so I haven't used kibit with boot myself, hence the somewhat elementary questions.

@danielcompton
Copy link
Member

It’s certainly possible, and I’d be happy to take a patch for it. Boot users can just call kibit with the src and test paths at the CLI with lein, but it would certainly be nicer to have native integration.

@seancorfield
Copy link
Member

seancorfield commented Jul 27, 2017

I just added a Kibit task to our Boot file:

(deftask kibit
  "Kibit checks code for idiomatic usage and makes suggestions."
  []
  (with-pass-thru fs
    (pod/with-eval-in (pod/make-pod (update-in (get-env)
                                               [:dependencies]
                                               conj
                                               '[lein-kibit "0.1.6-beta1"]))
      (require '[kibit.driver :refer [run]]
               '[clojure.java.io :as io])
      (run (for [folder ["src" "test"]
                 :let [file-path (io/file folder)]
                 :when (.exists file-path)]
             file-path)
           nil))))

It could be made a lot smarter than that but...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants