-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNS] Review proxied-dns-records #19311
[DNS] Review proxied-dns-records #19311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 1 total issue(s) found.
## IP addresses | ||
|
||
:::caution[Note to self] | ||
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx | |
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in Cloudflare-configuration.mdx |
Issues:
- Style Guide - (Terms-error) Use 'Cloudflare' instead of 'cloudflare'.
Fix Explanation:
The capitalization of 'cloudflare' should be corrected to 'Cloudflare' as per the style guide recommendation. This is a straightforward capitalization fix and does not fall under any exceptions such as code references or links.
Deploying cloudflare-docs with Cloudflare Pages
|
This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
Working on the content first. Will address redirects and hyperlinks when all the new pages are in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
15 files reviewed, 1 total issue(s) found.
## IP addresses | ||
|
||
:::caution[Note to self] | ||
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx | |
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in Cloudflare-configuration.mdx |
Issues:
- Style Guide - (Terms-error) Use 'Cloudflare' instead of 'cloudflare'.
Fix Explanation:
The term 'cloudflare' should be capitalized to 'Cloudflare' as it is a proper noun and not a code reference.
Closing this one in favor of a more iterative approach: will apply changes to proxy-status in a separate PR but refrain from changing folder structure or expanding the scope too much while we figure out what goes into DNS vs Fundamentals. |
Summary
PCX-14292
Documentation checklist