Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNS] Review proxied-dns-records #19311

Closed

Conversation

RebeccaTamachiro
Copy link
Contributor

Summary

PCX-14292

Documentation checklist

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 1 total issue(s) found.

## IP addresses

:::caution[Note to self]
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in Cloudflare-configuration.mdx

Issues:

  • Style Guide - (Terms-error) Use 'Cloudflare' instead of 'cloudflare'.

Fix Explanation:

The capitalization of 'cloudflare' should be corrected to 'Cloudflare' as per the style guide recommendation. This is a straightforward capitalization fix and does not fall under any exceptions such as code references or links.

Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: bea80af
Status: ✅  Deploy successful!
Preview URL: https://fc74b079.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev

View logs

Copy link

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /dns/manage-dns-records/reference/proxied-dns-records/

Copy link

github-actions bot commented Jan 20, 2025

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/dns/proxy-status/about-proxying/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/proxy-status/about-proxying/
https://developers.cloudflare.com/dns/proxy-status/proxied-records/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/proxy-status/proxied-records/
https://developers.cloudflare.com/dns/manage-dns-records/reference/proxied-dns-records/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/manage-dns-records/reference/proxied-dns-records/
https://developers.cloudflare.com/fundamentals/concepts/how-cloudflare-works/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/fundamentals/concepts/how-cloudflare-works/
https://developers.cloudflare.com/dns/proxy-status/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/proxy-status/
https://developers.cloudflare.com/dns/proxy-status/limitations/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/proxy-status/limitations/
https://developers.cloudflare.com/dns/proxy-status/cloudflare-configuration/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/proxy-status/cloudflare-configuration/
https://developers.cloudflare.com/dns/additional-options/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/additional-options/
https://developers.cloudflare.com/dns/cname-flattening/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/cname-flattening/
https://developers.cloudflare.com/dns/dns-firewall/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/dns-firewall/
https://developers.cloudflare.com/dns/dnssec/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/dnssec/
https://developers.cloudflare.com/dns/manage-dns-records/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/manage-dns-records/
https://developers.cloudflare.com/dns/reference/ https://rebecca-dns-revamp-proxied-d.cloudflare-docs-7ou.pages.dev/dns/reference/

@RebeccaTamachiro
Copy link
Contributor Author

RebeccaTamachiro commented Jan 20, 2025

Working on the content first. Will address redirects and hyperlinks when all the new pages are in place.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15 files reviewed, 1 total issue(s) found.

## IP addresses

:::caution[Note to self]
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in cloudflare-configuration.mdx
Consider not going into detail about ingress vs egress here. Maybe a better option would be making note of that while mentioning Address Maps in Cloudflare-configuration.mdx

Issues:

  • Style Guide - (Terms-error) Use 'Cloudflare' instead of 'cloudflare'.

Fix Explanation:

The term 'cloudflare' should be capitalized to 'Cloudflare' as it is a proper noun and not a code reference.

@RebeccaTamachiro
Copy link
Contributor Author

Closing this one in favor of a more iterative approach: will apply changes to proxy-status in a separate PR but refrain from changing folder structure or expanding the scope too much while we figure out what goes into DNS vs Fundamentals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants