Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn c3 commands #19464

Closed
deloreyj opened this issue Jan 27, 2025 · 4 comments
Closed

Fix yarn c3 commands #19464

deloreyj opened this issue Jan 27, 2025 · 4 comments
Assignees
Labels
content:edit Request for content edits documentation Documentation edits product:workers Related to Workers product

Comments

@deloreyj
Copy link
Contributor

Existing documentation URL(s)

Example doc: https://developers.cloudflare.com/workers/frameworks/

What changes are you suggesting?

The existing yarn C3 examples are broken because of the @latest flag. Trying to run the command produces the following error
Yarn create cloudflare error

The @latest is superfluous because yarn create downloads the latest version of the create script by default: https://classic.yarnpkg.com/lang/en/docs/cli/create/

The fix is to remove all of the @latest from yarn create commands

Additional information

No response

@deloreyj deloreyj added content:edit Request for content edits documentation Documentation edits labels Jan 27, 2025
@github-actions github-actions bot added the product:workers Related to Workers product label Jan 27, 2025
@kodster28
Copy link
Contributor

kodster28 commented Jan 27, 2025

@KianNH, is this a bug in the underlying PackageManagers component?
(or unrelated and I'm just getting turned around here)

@deloreyj
Copy link
Contributor Author

@kodster28 Digging deeper I think this might actually be an issue with C3. See this old PR: https://github.com/cloudflare/workers-sdk/pull/4311/files

Looks like their support may have broken. I'll continue to investigate today and if this issue is unnecessary I'll close it.

@deloreyj
Copy link
Contributor Author

nevermind that pull request would be a layer deeper than this issue (internal to C3 vs downloading and executing C3). Yeah I think we need a docs update to remove the @latest from the yarn commands. The linked PR changes all of the places where yarn create cloudflare@latest was hard coded in the docs.

You're right @kodster28 that there are a bunch of places where the PackageManagers component adds the command that we'll need to handle.

@kodster28
Copy link
Contributor

Will be mostly solved by HiDeoo/starlight-package-managers#29

kodster28 added a commit that referenced this issue Jan 30, 2025
* fix: #19464 remove @latest from yarn create cloudflare commands

* Update to packagemanagers where appropriate

* remove extra lines

---------

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: kodster28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content:edit Request for content edits documentation Documentation edits product:workers Related to Workers product
Projects
None yet
Development

No branches or pull requests

8 participants