Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs Site] Add trailingSlash: always to Astro config #19596

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

[Docs Site] Add trailingSlash: always to Astro config #19596

wants to merge 1 commit into from
+1 −0

Conversation

KianNH
Copy link
Contributor

@KianNH KianNH commented Jan 31, 2025

Summary

This was highlighted by a chance in our sidebar logic - we shouldn't "support" links like /workers and should direct people to /workers/ as all links and redirects written should use the trailing slash.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1859d12
Status: ✅  Deploy successful!
Preview URL: https://c5446624.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://kian-pcx-15650.cloudflare-docs-7ou.pages.dev

View logs

kodster28
kodster28 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, ty!

This is very annoying b/c otherwise we sometimes have to do double redirects for each version.

I should really set aside time quarterly to review our config options 😓

@GregBrimble
Copy link
Contributor

Consider html_handling = "force-trailing-slash" also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodster28 kodster28 kodster28 approved these changes

@kristianfreeman kristianfreeman Awaiting requested review from kristianfreeman kristianfreeman is a code owner

@pedrosousa pedrosousa Awaiting requested review from pedrosousa pedrosousa is a code owner

@haleycode haleycode Awaiting requested review from haleycode haleycode is a code owner

@maxvp maxvp Awaiting requested review from maxvp maxvp is a code owner

@marciocloudflare marciocloudflare Awaiting requested review from marciocloudflare marciocloudflare is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

Assignees

@pedrosousa pedrosousa

@kristianfreeman kristianfreeman

@maxvp maxvp

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@kodster28 kodster28

@marciocloudflare marciocloudflare

@haleycode haleycode

Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@KianNH @GregBrimble @kodster28 @pedrosousa @kristianfreeman @maxvp @WalshyDev @marciocloudflare @haleycode