Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check to see if the URL parameters are present before getting them #45

Open
tayabsoomro opened this issue Jul 31, 2021 · 0 comments
Labels
fortification These issues are there to make the code more robust

Comments

@tayabsoomro
Copy link
Member

tayabsoomro commented Jul 31, 2021

Current State
There are various instances in routes.py file where we are fetching the URL parameters without checking to see whether they exist. This causes the API to throw a python error which does not make sense.

Solution
In order to avoid that, we need to add various checks to ensure that the parameters that we are accessing actually do exist in the dictionary.

@tayabsoomro tayabsoomro added the fortification These issues are there to make the code more robust label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fortification These issues are there to make the code more robust
Projects
None yet
Development

No branches or pull requests

1 participant