Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move CI to github actions #87

Closed
jrochkind opened this issue Feb 28, 2022 · 2 comments
Closed

move CI to github actions #87

jrochkind opened this issue Feb 28, 2022 · 2 comments

Comments

@jrochkind
Copy link
Collaborator

This project is set up for CI on Travis, but Travis essentially doesn't provide free CI for open source anymore, and the CI doesn't currently appear to be running for this project.

I have had good experience with free Github Actions for CI. Reconstitute CI on Github Actions?
@mcritchlow
Copy link
Collaborator

Makes good sense to me. I've not yet used GH Actions, but might have time in a few weeks to take a pass at this, unless someone else wants to jump on it sooner.

jrochkind added a commit that referenced this issue Mar 28, 2022
@jrochkind
Support testing on Rails 6.1 and 7.0
6dd32d8 
We don't have CI working on this repo (See #87), but I manually ran tests in Rails 5.2, 6.0. 6.1, and 7.0 -- it passed on all of them with no changes

BUT there was a deprecation notice in 7. I went ahead and fixed the deprecation notice (also confirming by manually running tests that still passed on all those versions).

This will at least allow manual testing on more recent Rails versions, as well as set the path for testing on recent Rails when we restore CI.
@jrochkind
Copy link
Collaborator Author

Note CI won't currently pass in ruby 3.0, because of rexml dependency assumed in stdlib. #68

This was referenced Apr 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcritchlow @jrochkind