Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream? #18

Open
maccman opened this issue Oct 18, 2020 · 2 comments
Open

Merge upstream? #18

maccman opened this issue Oct 18, 2020 · 2 comments

Comments

@maccman
Copy link

maccman commented Oct 18, 2020

There are a ton of enhancements in this branch (Catalina support, promises etc) - just putting them on your radar in case you want to merge upstream.

https://github.com/lefooey/node-mac-contacts
@codebytere
Copy link
Owner

codebytere commented Oct 18, 2020 •
edited
Loading

@maccman oh interesting 👀 I'm not sure i'll take on all those changes (e.g i'd rather not return a promise for getAuthStatus probably) but there's some error handling & efficiency improvements in there i can absolutely incorporate.

Thanks for bringing this to my attention!

@codebytere
Copy link
Owner

@lefooey would you be interested in upstreaming any of the enhancements you've made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maccman @codebytere