Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code block overflow in instructions card #2423

Open
rohitpaulk opened this issue Nov 23, 2024 · 6 comments
Open

Fix code block overflow in instructions card #2423

rohitpaulk opened this issue Nov 23, 2024 · 6 comments
Assignees

Comments

@rohitpaulk
Copy link
Member

rohitpaulk commented Nov 23, 2024

https://app.codecrafters.io/courses/bittorrent/stages/hw0

Screenshot 2024-11-23 at 23 24 23
@VasylMarchuk
Copy link
Collaborator

VasylMarchuk commented Nov 24, 2024

So if I change the way this magnet link is defined in the instructions markdown from using single-ticks:

`magnet:?....`

to using triple-ticks, like this:

Знімок екрана 2024-11-24 о 12 24 24

then it works:

Знімок екрана 2024-11-24 о 12 20 30

@VasylMarchuk
Copy link
Collaborator

VasylMarchuk commented Nov 24, 2024

I assume there's a way to edit the instructions markdown — but I'm not sure where? @rohitpaulk

@rohitpaulk
Copy link
Member Author

Ah, gotcha - @andy1li can you make that change please? @VasylMarchuk the markdown is stored here, but needs an admin to go and "apply" an update in the app.

@VasylMarchuk can you see if there's a CSS fix to prevent this happening even for inline code blocks? I can imagine cases where there's a not-so-long inline code block causing the same issue on smaller screens.

@rohitpaulk
Copy link
Member Author

Probably worth looking at what GitHub does: thisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinline

@andy1li
Copy link
Member

andy1li commented Nov 25, 2024

Testing too: ABC thisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinlinethisisaverylongcodeblockthatisinline XYZ


Prod updated:

image

@VasylMarchuk
Copy link
Collaborator

Probably worth looking at what GitHub does:

Ah, looks like they're simply using word-wrap: break-word; — cool, going to try this for our styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants