Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding cleanup items #1054

Open
AuHau opened this issue Dec 30, 2024 · 1 comment
Open

Outstanding cleanup items #1054

AuHau opened this issue Dec 30, 2024 · 1 comment

Comments

@AuHau
Copy link
Member

AuHau commented Dec 30, 2024

In my cleanup work I mainly focused on removing unused imports, but there are 3 other types of issues that should get cleanuped:

Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/manifest/coders.nim(266, 16) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/codex/blockexchange/discovery/testdiscovery.nim(111, 25) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/streams/storestream.nim(107, 74) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/erasure/erasure.nim(221, 19) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/erasure/erasure.nim(221, 19) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/node.nim(546, 27) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/node.nim(546, 27) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
General
/Users/adam/Projects/status/nim-codex/codex/conf.nim(676, 7) Warning: Please use MetricsHttpServerRef API; startMetricsHttpServer is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/helpers/trackers.nim(11, 13) Warning: Please use getTrackerCounter() instead; getTracker is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/helpers/trackers.nim(14, 13) Warning: Please use getTrackerCounter() instead; getTracker is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/helpers/trackers.nim(18, 17) Warning: Please use getTrackerCounter() instead; getTracker is deprecated [Deprecated]
Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/randomchunker.nim(28, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/randomchunker.nim(28, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/randomchunker.nim(28, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/testchunking.nim(24, 5) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/codex/chunker.nim(85, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/codex/chunker.nim(118, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/mockchunker.nim(23, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/testasyncstreamwrapper.nim(36, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/codex/testasyncstreamwrapper.nim(55, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/codex/testasyncstreamwrapper.nim(76, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
@2-towns
Copy link
Contributor

2-towns commented Jan 10, 2025

After the Nim 2.0.14 there are more:

Warning: imported and not used
/share/home/arnaud/Work/codex/nim-codex/codex/errors.nim(1, 2) Warning: imported and not used: 'libbacktrace' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/errors.nim(1, 2) Warning: imported and not used: 'logging' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/json.nim(1, 2) Warning: imported and not used: 'libbacktrace' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/json.nim(1, 2) Warning: imported and not used: 'logging' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/logutils.nim(1, 2) Warning: imported and not used: 'libbacktrace' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/logutils.nim(1, 2) Warning: imported and not used: 'logging' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/blockexchange/peers/peerctxstore.nim(12, 11) Warning: imported and not used: 'algorithm' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/nat.nim(13, 9) Warning: imported and not used: 'objects' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/codex/conf.nim(15, 11) Warning: imported and not used: 'terminal' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/slots/testprover.nim(14, 23) Warning: imported and not used: 'poseidon2digest' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/node/testcontracts.nim(12, 11) Warning: imported and not used: 'taskpools' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/blockexchange/engine/testengine.nim(7, 18) Warning: imported and not used: 'errors' [UnusedImport]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/blockexchange/discovery/testdiscovery.nim(7, 18) Warning: imported and not used: 'errors' [UnusedImport]
Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/errors.nim(12, 16) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/asyncheapqueue.nim(12, 16) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/nat.nim(13, 17) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/natutils.nim(5, 7) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/stores/testqueryiterhelper.nim(3, 16) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/testasyncheapqueue.nim(2, 16) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/erasure/backends/leopard.nim(13, 16) Warning: `stew/results` is now available as `import results` via the `results` Nimble package; results is deprecated [Deprecated]
Warning: template 'activeChroniclesScope' is implicitly redefined; this is deprecated, add an explicit .redefine pragma [ImplicitTemplateRedefinition]
/share/home/arnaud/Work/codex/nim-codex/vendor/nim-chronicles/chronicles.nim(74, 14) Warning: template 'activeChroniclesScope' is implicitly redefined; this is deprecated, add an explicit .redefine pragma [ImplicitTemplateRedefinition]

Warning: use std/net; net is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/discovery.nim(17, 22) Warning: use std/net; net is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/conf.nim(30, 27) Warning: use std/net; net is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/nat.nim(12, 58) Warning: use std/net; net is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/natutils.nim(5, 32) Warning: use std/net; net is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/addrutils.nim(17, 22) Warning: use std/net; net is deprecated [Deprecated]
Warning: use exitprocs.addExitProc; addQuitProc is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/codex/nat.nim(293, 7) Warning: use exitprocs.addExitProc; addQuitProc is deprecated [Deprecated]
Warning: use {.base.} for base methods; baseless methods are deprecated [UseBase]
/share/home/arnaud/Work/codex/nim-codex/codex/streams/storestream.nim(131, 8) Warning: use {.base.} for base methods; baseless methods are deprecated [UseBase]
/share/home/arnaud/Work/codex/nim-codex/codex/streams/asyncstreamwrapper.nim(89, 8) Warning: use {.base.} for base methods; baseless methods are deprecated [UseBase]
Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/testchunking.nim(106, 28) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/testchunking.nim(106, 28) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/testasyncstreamwrapper.nim(36, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/testasyncstreamwrapper.nim(55, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/share/home/arnaud/Work/codex/nim-codex/tests/codex/testasyncstreamwrapper.nim(76, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
/share/home/arnaud/Work/codex/nim-codex/codex/utils/options.nim(19, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
Other
/share/home/arnaud/Work/codex/nim-codex/vendor/nim-circom-compat/circomcompat.nim(17, 3) Warning: cargo build --release --manifest-path=vendor/circom-compat-ffi/Cargo.toml [User]
/share/home/arnaud/Work/codex/nim-codex/vendor/nim-circom-compat/circomcompat.nim(23, 3) Warning: circom compat ffi built successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants