-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative format for GitHub PR annotations #91
Comments
Hi @mroy-seedbox, Thank you for your kind words, they mean a lot! I think you are proposing a wonderful enhancement. I always wanted to do it, but never got around to implementing a compatible output. Would you be interested in contributing this feature yourself? It's not too difficult, you can find GitHub's documentation here: Cheers! |
Absolutely! 🙌 I don't have the time for it right now, but I'll circle back to this as soon as I have more capacity! |
@mroy-seedbox I found a minute to quickly address this. Thanks for bringing this to my attention. It's a much appreciated addition, and I honestly didn't know how easy this was to implement. Thanks! |
Just made the change to have this in our CI/CD pipeline, and it's working well! Thank you! 🙌 |
The next iteration on this would be to add file groups, like this. It's a pretty simple change! |
I thought about that, but do they do anything in the interface? It looks different in the run logs, but the line annotations on a PR stays the same, right? |
It's done @mroy-seedbox. It's with grouping now. |
Awesome, thank you so much!! 🙌 🙏 💙 |
First of all, thank you for the amazing Swiss army knife that is reLint! 🙏 💙
We use it to augment the linting that SQLFluff provides, since it only covers the basics (and not all of our SQL coding standards).
This feature request is basically to be able to easily post reLint results as annotation in GitHub PRs. Basically, something similar to what SQLFluff is doing:
--format github-annotation-native
.Or do you think this is something that belongs outside of the reLint codebase? (kinda like container images)
If reLint doesn't provide alternative formats, then it would mean having to parse the reLint results in order to convert them into a different format. Not ideal, but doable. But a more machine-readable format would definitely help. Something like JSON might be ideal.
And aNevermind! It looks like this already happens automatically when there is no tty! 🙌-n/--nocolor
option could also be helpful, so that the output is more machine-readable. Although if raw JSON format is provided, then this option would be unnecessary.The text was updated successfully, but these errors were encountered: