Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password saved in plain text in mongo db #169

Open
GAstraeus opened this issue Oct 24, 2022 · 3 comments
Open

Password saved in plain text in mongo db #169

GAstraeus opened this issue Oct 24, 2022 · 3 comments

Comments

@GAstraeus
Copy link

Going into the mongodb shell and showing the setting collection reveals the authCredentials password in plain text

Reproduction

Used commands:
mongosh
use pisignage-server-dev
db.settings.find()

Sample Output Showing the password in plaintext

[
  {
    _id: ObjectId("object-id"),
    authCredentials: { user: 'admin-username', password: 'ADMIN-PASSWORD-IN-PAINTEXT' },
    installation: 'pi-signage-username',
    newLayoutsEnable: false,
    systemMessagesHide: true,
    forceTvOn: false,
    disableCECPowerCheck: false,
    defaultDuration: 10,
    language: 'en',
    sshPassword: null,
    enableLog: false,
    hideWelcomeNotice: true,
    reportIntervalMinutes: 5,
    enableYoutubeDl: true,
    __v: 0
  }
]

Possible In scope:

  • Add measures to salt and hash the password before it gets saved to db
  • Change auth check to handle checking against hashed password
  • Test for functionality of authentication, and setting new password

Resources Found

@rmscode
Copy link

rmscode commented Jul 17, 2023

Approaching 2 years and this hasn't been addressed yet?

@colloqi
Copy link
Owner

colloqi commented Jul 18, 2023

Hi, this is used by players in the internal network and http auth. We are not planning to solve this as of now.

@ebandur-fshark
Copy link

Would love for this to be addressed. At least more security added for open-source servers. 2FA, SSO, different password for players than server, no plain text on players and MongoDB, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants