Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer Research Object Bundle creation ; or drop altogether? #305

Open
mr-c opened this issue Mar 31, 2021 · 3 comments
Open

Defer Research Object Bundle creation ; or drop altogether? #305

mr-c opened this issue Mar 31, 2021 · 3 comments

Comments

@mr-c
Copy link
Member

mr-c commented Mar 31, 2021

The creation of the Research Object Bundle is the source of much complexity and delays, but is likely not used by the majority of CWL viewer users.

The CWL viewer should be refactored so that the creation of the RO Bundle does not delay the visualization of the provided workflow. This could even mean that it is not created at all unless requested by the user via an additional click.

@mr-c
Copy link
Member Author

mr-c commented Jun 1, 2021

Possibly stop making the research object bundle. @stain is there a reason to keep that code?

@mr-c mr-c changed the title Defer Research Object Bundle Defer Research Object Bundle creation ; or drop altogether? Jun 2, 2021
@mr-c
Copy link
Member Author

mr-c commented Jun 2, 2021

The WorkflowHub.eu supports the successor to Research Object Bundles, RO-Crate and will even create RO-Crates when one registers a workflow there.

So I propose that we completely remove the "Download as Research Object Bundle" link and all code that supports that and isn't used for another feature.

image

The Permalink should stay; I think that is still an important feature.

@mr-c
Copy link
Member Author

mr-c commented Jun 2, 2021

@stain writes

I don't think the RO Bundle complicates code too much as it is mainly run as side jobs. The WorkflowHub has not got the same content (yet) in the RO-Crate e.g. the TTL conversion and the packed workflow. The RO Bundle is imperfect though, e.g. it does not include ../tools/foo.cwl in the archive.

In WorkflowHub this would not be there fully before we get the GitHub integration proper by autumn 2021.

If you add a registration mechanism to WFHub then it could help to make DOIs etc

For cWL viewer I think adding visualization of tools would be nice, secondly some kind of grouping of workflows in different commits or paths of same repo.. there are now 25.000 "workflows".

cwltool can run straight off the raw.githubblabla links, but it can be a bit slow because it does not cache. Also wont be so easy in non-github repos
also wont work with git submodules

now it is running in the cloud then continued shallow clone may use more traffic than to check each repo once... but you have less working disk space (before we had 1 TB)

@obasekiosa, @tetron So lets not drop the Research Object Bundle feature for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant