-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document running mvn test + docker compose #322
Comments
A new compose file e.g docker-compose-test.yml can be created with the content of docker-compose.yml and the new changes. Then we can run docker compose -f docker-compose-test.yml up. This starts up the application with the contents of the test.yml thereby leaving docker-compose the way it is. |
It would be best to not "repeat ourselves" by having the same contents in two files, perhaps https://docs.docker.com/compose/extends/ has a hint? |
Okay, so the new test.yml shouldn't repeat all the contents rather it should just contain the new changes right ? |
Correct! |
Alright then. Thanks |
Hi @mr-c , can you talk about this task a bit more, I'm not certain I fully understand it so I haven't been able to work on it. Secondly, Is the documentation here similar to the docs I wrote on #327. I will also love to understand the difference between these yml files. a/docker-compose.yml b/docker-compose.yml. |
I think what is required is a setup with adequate documentation that explains to users of this project the steps required to run tests without having to modify docker compose files that come with the project. |
Okay so it is similar to #327 right? |
Yes it's actually very similar but not quite the same. Without going too much into unnecessary detail. In this issue what's required is a docker compose configuration file that allows a user to connect and run all required tests. https://docs.docker.com/compose/extends/ Note: something similar is already implemented in the project. |
Okay just a file is what is needed. |
With adequate documentation. You could choose to add the file yourself or give instructions on how to create and use such a file. |
okay thanks |
Keep in mind a criteria is to ensure docker-compose.yml is never edited manually. |
yea i already got that |
No i don't have it installed |
You have to install it. |
okay |
Can this be done without editing
docker-compose.yml
?The text was updated successfully, but these errors were encountered: