Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config clean command sketch #17514

Open
wants to merge 23 commits into
base: develop2
Choose a base branch
from
Open

Config clean command sketch #17514

wants to merge 23 commits into from

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Dec 19, 2024 •
edited
Loading

Changelog: Feature: Adds conan config clean command that will remove all custom config from conan home, excluding the generated packages
Changelog: Feature: Add reinit method to ConanApi, which reinitializes every subapi
Docs: TODO

Addresses the remaining point of #12842

Close #5935
Close #12842
Close #17578

@AbrilRBS AbrilRBS changed the title Clean command sketch Config clean command sketch Dec 19, 2024
memsharded
memsharded reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good idea, and necessary, thanks very much for doing it!

Maybe reset is a better name if the intent is to reset to "factory defaults"? I am fine with either name, just nitpicking.

@AbrilRBS AbrilRBS added this to the 2.12.0 milestone Dec 24, 2024
memsharded
memsharded reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

conan/cli/commands/config.py Outdated Show resolved Hide resolved
AbrilRBS
AbrilRBS commented Jan 10, 2025
View reviewed changes
conan/api/conan_api.py Outdated Show resolved Hide resolved
conan/api/conan_api.py Show resolved Hide resolved
@AbrilRBS AbrilRBS marked this pull request as ready for review January 10, 2025 09:39
AbrilRBS
AbrilRBS commented Jan 13, 2025
View reviewed changes
conans/client/migrations.py Show resolved Hide resolved
conan/api/subapi/remotes.py Show resolved Hide resolved
memsharded
memsharded reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@AbrilRBS AbrilRBS marked this pull request as draft January 14, 2025 08:47
AbrilRBS
AbrilRBS commented Jan 14, 2025
View reviewed changes
conan/api/subapi/config.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS marked this pull request as ready for review January 14, 2025 08:57
memsharded
memsharded reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just 2 small details to close

conan/api/subapi/config.py Show resolved Hide resolved
@memsharded memsharded mentioned this pull request Jan 15, 2025
Open
1 task
@AbrilRBS AbrilRBS marked this pull request as draft January 17, 2025 08:33
@AbrilRBS
Copy link
Member Author

We're losing all core-confs after a reinit

@AbrilRBS AbrilRBS marked this pull request as ready for review January 17, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@czoido czoido czoido approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.12.0
4 participants
@AbrilRBS @franramirez688 @czoido @memsharded