Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe requirements out of sync with requirements.txt #15

Closed
1 task done
scottyhq opened this issue Sep 15, 2023 · 2 comments · Fixed by #16
Closed
1 task done

Recipe requirements out of sync with requirements.txt #15

scottyhq opened this issue Sep 15, 2023 · 2 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@scottyhq
Copy link

scottyhq commented Sep 15, 2023

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

@ocefpaf @gmaze some packages like gsw can apparently be removed.

Comparing
https://github.com/euroargodev/argopy/blob/v0.1.13/requirements.txt

With

requirements:
host:
- python >=3.6
- setuptools >=42
- pip
run:
- python >=3.6
- xarray >=0.16
- scipy >=1.5
- netcdf4 >=1.5.3
- toolz >=0.8.2
- erddapy >=0.7
- fsspec >=0.8
- aiohttp >=3.7
- packaging >=20.4
# imports pkg_resources
- setuptools >=42
# extras
- dask-core >=2.3
- gsw <=3.4.0
- scikit-learn >=0.23

Installed packages

n/a

Environment info

Ran into this issue trying to get as up-to-date versions of gsw, erddapy, and argopy in the same environment (pangeo-data/pangeo-docker-images#461 (comment))

@ocefpaf
Copy link
Member

ocefpaf commented Sep 15, 2023

I'll leave to @gmaze to define if we should remove the extras or not. But my guess is that we can drop the gsw pin there and things should work.

@gmaze
Copy link

gmaze commented Sep 18, 2023

Yes, we can drop gsw and basically the extra (dask-core, gsw, scikit-learn)

what must be there is:

  • xarray>=0.18
  • scipy>=1.5
  • netCDF4>=1.5.3 #<1.5.9
  • toolz>=0.8.2
  • erddapy>=0.7
  • fsspec>=0.8
  • aiohttp>=3.7
  • packaging>=20.4
  • requests>=2.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants