-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe is no longer updating #26
Comments
As far as I understand we have to delete pyproject.toml files in conda forge, because it's a conflict. Conda's meta.yaml is a build instruction and so is pyproject.toml. See: conda-forge/conda-forge.github.io#1174 |
Lots of recipes have this:
|
Ah, OK! |
If that doesn't work I put a |
I can make a PR with the update if you want. |
Oh, thanks! There are also some requirements simplifications, minimum Python >=3.6, and we now depend on pytest for testing: https://github.com/urschrei/pyzotero/blob/ed4175e0f1a62f10984b311864c13ac453fa9ebe/setup.cfg#L35-L47 |
See #27 |
There is a PR here with the possible official recommendations: conda-forge/conda-forge.github.io#1540 |
Amazing, thanks. That should be the last of the structural changes – hopefully there'll be something more robust in place on the conda side by the time "migrate everything to pyproject.toml" becomes a hard recommendation, but I'm not in a rush to repeat any of this… |
I'm not sure how that will play out. The pyproject.toml is effectively build instructions, just like conda's meta.yaml and any other package manager's spec file. Maybe there will be a way to extract info from the pyproject.toml file to be incorporated into a package manager's spec file. |
Maybe something like: https://github.com/dojeda/poetry2conda |
@moorepants Sorry to ping you, but I'm only an occasional Anaconda user – the recipe is no longer updating. I restructured the package (Python 3 only, using
pyproject.toml
+setup.cfg
) to incorporate new best practices but I don't know whether that's the issue. Let me know if there's anything I can do from my end…The text was updated successfully, but these errors were encountered: