Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Callable config optoins #1021

Open
soapy1 opened this issue Dec 13, 2024 · 0 comments
Open

Deprecate Callable config optoins #1021

soapy1 opened this issue Dec 13, 2024 · 0 comments
Labels

Comments

@soapy1
Copy link
Contributor

soapy1 commented Dec 13, 2024

Context

CondaStore.validate_specification and CondaStore.validate_action are settings which currently allow users to define their own functions for validating specs and actions. Additionally CondaStore.post_update_environment_build_hook allows users to specify actions to take after updating an environment As we move away from traitlets and python config files as per #1005 it does't make sense to continue to support config files that make heavy use of functionality provided by python. For example, users shouldn't be able to inject runnable code in the config file.

The following config values are Callable and should be deprecated:

  • CondaStore.validate_specification
  • CondaStore.validate_action
  • CondaStore.post_update_environment_build_hook

Instead, it would be better to expose this type of functionality to users thru plugin hooks.

Value and/or benefit

  • users shouldn't be able to inject code from the config file
    • as we move away from python config files, we will not be able to support this pattern
  • users should be able to customize conda-store by using plugins
@soapy1 soapy1 added area: configuration ⚙️ needs: discussion 💬 This item needs team-level discussion before scoping type: deprecations ⛔️ labels Dec 13, 2024
@soapy1 soapy1 changed the title Deprecate CondaStore.validate_specification and CondaStore.validate_action config Deprecate Callable config optoins Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New 🚦
Development

No branches or pull requests

1 participant