Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate docker registry #942

Open
soapy1 opened this issue Oct 31, 2024 · 5 comments · May be fixed by #1016
Open

Deprecate docker registry #942

soapy1 opened this issue Oct 31, 2024 · 5 comments · May be fixed by #1016
Assignees
Labels
area: api 🌐 area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠

Comments

@soapy1
Copy link
Contributor

soapy1 commented Oct 31, 2024

Context

Conda-store was once able to build docker images and host them in it's own docker registry. The docker workflows for conda store have fallen into disrepair and is have not been used by anyone in some time. It would be nice to remove this feature to reduce cruft in the code base. If it becomes clear that it would be helpful to have this feature again, it should be re-implemented with a more modern approach.

Value and/or benefit

The goal of this is to remove cruft and simplify the conda-store app.

related to #941

@soapy1 soapy1 added area: api 🌐 area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠 labels Oct 31, 2024
@soapy1
Copy link
Contributor Author

soapy1 commented Oct 31, 2024

@peytondmurray do you have opinions about if this should go thru a proper deprecation cycle, or if it's ok to yank out? I'm not sure anyone is using it, but the feature does still seem to work when I tested in locally. I'd be ok with deprecating and removing over a few releases.

@peytondmurray
Copy link
Contributor

@trallard @kcpevey @Adam-D-Lewis @krassowski Bringing this to your attention - any concerns about removing this iteration of the docker feature?

@Adam-D-Lewis
Copy link
Contributor

I'm not aware of anyone using it, but could we at least document what seems to be going wrong at the moment? I wasn't aware that it no longer was working.

@soapy1
Copy link
Contributor Author

soapy1 commented Nov 1, 2024

@Adam-D-Lewis I believe the registry is working, but building docker images has been disabled https://github.com/conda-incubator/conda-store/blob/main/conda-store-server/conda_store_server/_internal/worker/build.py#L423, looks like for the past year. I think if conda-store isn't building docker images, there isn't really too much use for a registry.

@peytondmurray
Copy link
Contributor

Looks like it never really went through a formal deprecation cycle anyway, it just got turned off. But it looks like it should have been generating warning messages about the feature not working...so maybe it's fine to remove at this point?

@soapy1 soapy1 moved this from New 🚦 to TODO 📬 in conda-store 🐍 Nov 12, 2024
@soapy1 soapy1 mentioned this issue Dec 6, 2024
3 tasks
@soapy1 soapy1 self-assigned this Dec 9, 2024
@soapy1 soapy1 moved this from TODO 📬 to In Progress 🏗 in conda-store 🐍 Dec 10, 2024
@soapy1 soapy1 linked a pull request Dec 10, 2024 that will close this issue
3 tasks
@soapy1 soapy1 changed the title Remove docker registry Deprecate docker registry Dec 10, 2024
@soapy1 soapy1 moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Dec 23, 2024
@soapy1 soapy1 mentioned this issue Jan 1, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api 🌐 area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠
Projects
Status: In review 👀
Development

Successfully merging a pull request may close this issue.

3 participants